Support cc_lib targets that only provide a dynamic library - #4249
Merged
Merged
Conversation
Collaborator
|
Thanks for the contributions! Please can you split the rust_analyzer change into a separate PR, and add a test to it? I'm happy to merge the bindgen change if you separate out the rust_analyzer one for separate review. |
illicitonion
added
the
awaiting-response
Author
|
Yap I can separate the 2 fixes into 2 PR's. I'm not entirely sure how I should test the rust_analyzer fix. I'll try to find a way. |
backtr4ce
changed the title
cc_lib targets that only provide a dynamic library and prevent re-anchoring when siblings are generatedcc_lib targets that only provide a dynamic library
Author
|
@illicitonion I splited the changes into two PR's. If anything wasn't done correctly, please inform me. |
krasimirgg
self-requested a review
September 28, 2026 12:29
krasimirgg
removed
the
awaiting-response
Collaborator
|
@krasimirgg I see you self requested the review, I'll defer the rest here to you 😄 |
Collaborator
|
this (bindgen change) looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues I've raised a while ago. Specifically:
rust_analyzer_aspectemits the wrong crate root for mixed source/generated crates #4234rust_bindgenrejectsCcInfodependencies with only a dynamic library #4233I signed the CLA with the Mail which I used to create the commit.